Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cosmos SDK v47 integration (backport: #1782) #278

Merged
merged 78 commits into from
Aug 1, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 14, 2023

for more info

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review June 15, 2023 01:58
@mmsqe mmsqe requested a review from yihuang June 15, 2023 01:59
rpc/backend/utils.go Outdated Show resolved Hide resolved
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
rpc/types/utils.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor suggestions.

go.mod Outdated Show resolved Hide resolved
@mmsqe mmsqe merged commit 2df0533 into crypto-org-chain:develop Aug 1, 2023
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants